Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows tokio (4d514b7) to compile on FreeBSD again. Prior to this change the following error was encountered:
This is on FreeBSD 11.1-RELEASE-p6, rustc 1.24.0.
I had a hard time working out where this
hup
function was supposed to be coming from. I came up with the following changes, which compile and the test suite passes. I fully admit I haven't studied the code enough to really know what is supposed to be happening though. Additionally I haven't tested the DragonflyBSD change but assume it's also in the same camp. Further review appreciated.