Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on FreeBSD #218

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Fix build on FreeBSD #218

merged 2 commits into from
Mar 13, 2018

Conversation

wezm
Copy link
Contributor

@wezm wezm commented Mar 11, 2018

This PR allows tokio (4d514b7) to compile on FreeBSD again. Prior to this change the following error was encountered:

error[E0425]: cannot find function `hup` in this scope
   --> src/reactor/poll_evented.rs:443:9
    |
443 |         hup() | UnixReady::aio() | UnixReady::lio()
    |         ^^^ not found in this scope

This is on FreeBSD 11.1-RELEASE-p6, rustc 1.24.0.

I had a hard time working out where this hup function was supposed to be coming from. I came up with the following changes, which compile and the test suite passes. I fully admit I haven't studied the code enough to really know what is supposed to be happening though. Additionally I haven't tested the DragonflyBSD change but assume it's also in the same camp. Further review appreciated.

@wezm
Copy link
Contributor Author

wezm commented Mar 12, 2018

Fixes #219

@carllerche
Copy link
Member

@wezm don't worry about a screenshot.

@carllerche
Copy link
Member

@wezm it looks like the all() function isn't used anymore? Perhaps it can just be deleted?

@wezm
Copy link
Contributor Author

wezm commented Mar 12, 2018

@carllerche You're right. I've removed it and all seems well.

@carllerche
Copy link
Member

Thanks!

@carllerche carllerche merged commit 2abeff0 into tokio-rs:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants