codec: Add Framed::with_capacity
#2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are using Framed::new() in order to construct your frame from an AsyncRead + AsyncWrite item, would it be possible to also have this capacity? |
|
Actually, one more thing, would it make sense to add this API to |
|
Got |
LucioFranco
approved these changes
Mar 2, 2020
LucioFranco
changed the title
Framed::with_capacity
sthagen
added a commit
to sthagen/tokio-rs-tokio
that referenced
this pull request
Mar 2, 2020
codec: Add `Framed::with_capacity` (tokio-rs#2215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FramedReadusers may want to set it's internal buffer size to minimize the chances of it being reallocated.In a variety of cases, it is possible to make a good guess on the frame size. Let this be configured instead of sticking with
framed_read::INITIAL_CAPACITYof8k.Relates to #2156.