Notify task when resetting a Delay to a time in the past #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleimkuhler
reviewed
Mar 2, 2020
thomaswhiteway
force-pushed
the
reset_delay_past
branch
from
5c350bc
to
8bb4f99
Compare
|
Just a heads up that CI uses this rustfmt command: |
thomaswhiteway
force-pushed
the
reset_delay_past
branch
from
8bb4f99
to
26ae1b5
Compare
|
@thomaswhiteway If you can fix the merge conflict on this it should be good to go. Sorry this has not merged yet! |
jonhoo
added
A-tokio
thomaswhiteway
force-pushed
the
reset_delay_past
branch
from
26ae1b5
to
90b49c9
Compare
If a Delay has been polled then the task that polled it may be waiting for a notification. If the delay gets reset to a time in the past, then it immediately becomes elapsed, so should notify the relevant task.
thomaswhiteway
force-pushed
the
reset_delay_past
branch
from
90b49c9
to
c5fa4bf
Compare
Darksonn
removed
E-finish-line
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Delay has been polled then the task that polled it may be waiting
for a notification. If the delay gets reset to a time in the past, then
it immediately becomes elapsed, so should notify the relevant task.
Motivation
Under certain conditions
DelayQueuemay update the current deadline to be in the past. The delay would immediately transition to elapsed, but wouldn't notify the appropriate task so the scheduler would never re-poll it.Solution
When resetting the time on a
Delay, if theEntryis transitioning intoELAPSEDstate call the waker to wake any registered task.