Keep lock until sender notified #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthias247
approved these changes
Mar 9, 2020
sthagen
added a commit
to sthagen/tokio-rs-tokio
that referenced
this pull request
Mar 9, 2020
Keep lock until sender notified (tokio-rs#2302)
|
This was intentional. Holding the lock while notifying is unnecessary. If you believe it is a bug, we should isolate it with a look test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_lock
Solution
Binding the tail's lock keeps it acquired until
notify_allis called