Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Ensure the visibility modifier is propagated when constructing a task local #2416

Merged
merged 1 commit into from Apr 20, 2020

Conversation

gardnervickers
Copy link
Member

Ensure the visibility modifier is propagated static when constructing a task_local!.

@gardnervickers gardnervickers changed the title task: Ensure the visibility modifier is propagated task: Ensure the visibility modifier is propagated when constructing a task local Apr 18, 2020
@gardnervickers gardnervickers added A-tokio Area: The main tokio crate M-task Module: tokio/task C-bug Category: This is a bug. labels Apr 19, 2020
@Darksonn Darksonn added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2020
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch!

@LucioFranco LucioFranco merged commit 6edc64a into master Apr 20, 2020
@LucioFranco LucioFranco deleted the taskid-vis branch April 20, 2020 16:40
@Darksonn Darksonn added relnotes and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2020
@Darksonn Darksonn removed the relnotes label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-task Module: tokio/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants