Remove relative link when possible and fix invalid links #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to tokio::main was relative to tokio_macros crate in the source directory. This is why it worked in local build of documentation and not in doc.rs. Related to tokio-rs#1473.
Use rustdoc automatic link resolution over relative path to have compile time error when it could not resolve links. Fix invalid links to AsyncRead and AsyncWrite in tokio-util. Related to tokio-rs#1473.
Darksonn
reviewed
Apr 21, 2020
Darksonn
added
C-maintenance
Darksonn
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces relative links by rusdoc link resolution when possible to have a compile error when links cannot be resolved.
Fix invalid links to AsyncRead and AsyncWrite in tokio-util.
Fix link to tokio::main in Runtime::new().