Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: set task budget after block_in_place call #2502

Merged
merged 3 commits into from
May 7, 2020
Merged

Conversation

carllerche
Copy link
Member

@carllerche carllerche commented May 7, 2020

In some cases, when a call to block_in_place completes, the runtime is
reinstated on the thread. In this case, the task budget must also be set
in order to avoid starving other tasks on the worker.

In some cases, when a call to `block_in_place` completes, the runtime is
reinstated on the thread. In this case, the task budget must also be set
im order to avoid starving other tasks on the worker.
@carllerche carllerche requested a review from jonhoo May 7, 2020 21:14
@carllerche carllerche added A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-runtime Module: tokio/runtime labels May 7, 2020
tokio/tests/rt_threaded.rs Show resolved Hide resolved
tokio/src/coop.rs Show resolved Hide resolved
@carllerche carllerche merged commit bff21ab into master May 7, 2020
@Darksonn Darksonn deleted the block-in-place-coop branch May 8, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants