Expose ability to acquire multiple permits #2598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
Darksonn
reviewed
Jun 9, 2020
There was a problem hiding this comment.
Can you add the new async fns to tokio/tests/async_send_sync.rs?
hawkw
reviewed
Jun 10, 2020
There was a problem hiding this comment.
Overall, this looks great. I had a few thoughts on API design I'd love to hear your thoughts on.
Also, it would be good to get a +1 from @carllerche before merging this — I don't remember off the top of my head if there was any more specific motivation for not exposing multiple permits in the public Semaphore API, or if it just hadn't been done yet.
|
Can you merge master for CI fixes? |
This was referenced Jun 10, 2020
kornelski
force-pushed
the
semaphoren
branch
2 times, most recently
from
dd57ee1
to
ea6cd8a
Compare
|
Seems we should PR sent: kornelski#1 |
|
PR sent: kornelski#2 |
* commit 'd7b7d2c26d8952478c51c946633fa80f7764a104': Support larger number of permits
|
Closing due to #2605 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1550
Rebased on #2605 and #2607