Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: move CancellationToken to tokio-util #2721

Merged
merged 4 commits into from Aug 23, 2020
Merged

sync: move CancellationToken to tokio-util #2721

merged 4 commits into from Aug 23, 2020

Conversation

carllerche
Copy link
Member

The CancellationToken utility is only available with the
tokio_unstable flag. This was done as the API is not final, but it
adds friction for users.

This patch moves CancellationToken to tokio-util where it is generally
available. The tokio-util crate does not have any constraints on
breaking change releases.

@carllerche
sync: move CancellationToken to tokio-util
edad26a 
The `CancellationToken` utility is only available with the
`tokio_unstable` flag. This was done as the API is not final, but it
adds friction for users.

This patch moves `CancellationToken` to tokio-util where it is generally
available. The tokio-util crate does not have any constraints on
breaking change releases.
@carllerche carllerche mentioned this pull request Jul 30, 2020
Closed
@Darksonn Darksonn added A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-sync Module: tokio/sync labels Jul 30, 2020
davidbarsky
davidbarsky approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this was reviewed, but I think I commented on a previous PR that removed CancellationToken wholesale. I think this can reasonably be merged in.

@Darksonn Darksonn merged commit 9d58b70 into master Aug 23, 2020
@Darksonn Darksonn deleted the move-cancellation-token branch August 23, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carllerche @davidbarsky @Darksonn