Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: expose Chain stream #2722

Closed
wants to merge 1 commit into from
Closed

io: expose Chain stream #2722

wants to merge 1 commit into from

Conversation

SergioBenitez
Copy link

This commit simply makes the Chain adapter stream public. This allow the type to be referenced in dependent crates.

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-stream Module: tokio/stream labels Jul 30, 2020
@Darksonn
Copy link
Contributor

We don't want to do this one adapter at the time. To get something like this merged, it should take all the combinators, but not the futures. #2188 (comment)
Additionally I don't think we want to do this right now, as described here: #2718

@Darksonn Darksonn closed this Jul 30, 2020
@SergioBenitez
Copy link
Author

SergioBenitez commented Jul 30, 2020 •
edited

Which are the "combinators"? Do you mean adapters? If so, besides Take and Chain, which others are there that aren't already pub? Edit: I see that the adapters in StreamExt are called combinators. Those types seem orthogonal to Chain, and so it seems logical to have two different commits: the Chain type does not belong in stream.

@Darksonn Darksonn added M-io Module: tokio/io and removed M-stream Module: tokio/stream labels Jul 30, 2020
@Darksonn
Copy link
Contributor

I think that AsyncRead and Stream combinators are the same question. We can continue the discussion in #2723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergioBenitez @Darksonn