Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: make UCred fields private #2936

Merged
merged 3 commits into from Oct 11, 2020
Merged

net: make UCred fields private #2936

merged 3 commits into from Oct 11, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 9, 2020

Refs: #2928

@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
21 tasks
@taiki-e taiki-e added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 9, 2020
Darksonn
Darksonn reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uid_t and gid_t types are just integers. I'd probably just go for methods that return them by-copy.

carllerche
carllerche previously requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 minor request. I would remove the &mut accesors for the time being until there is a request for them.

tokio/src/net/unix/ucred.rs Outdated Show resolved Hide resolved
tokio/src/net/unix/ucred.rs Outdated Show resolved Hide resolved
@taiki-e
Copy link
Member Author

taiki-e commented Oct 9, 2020

I would remove the &mut accesors for the time being until there is a request for them.

Make sense, I removed them.

@Darksonn Darksonn dismissed carllerche’s stale review October 11, 2020 07:31

The concerns have been resolved

@Darksonn Darksonn merged commit b047f64 into tokio-rs:master Oct 11, 2020
@Darksonn Darksonn mentioned this pull request Oct 11, 2020
Merged
@taiki-e taiki-e deleted the net-ucred branch October 11, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@carllerche carllerche carllerche left review comments

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taiki-e @carllerche @Darksonn