Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: move broadcast error types into broadcast::error module #2937

Merged
merged 4 commits into from Oct 9, 2020
Merged

sync: move broadcast error types into broadcast::error module #2937

merged 4 commits into from Oct 9, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 9, 2020

Refs: #2928

This also adds missing {Display, Error} impls for broadcast::error::SendError.

@taiki-e taiki-e added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Oct 9, 2020
@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
21 tasks
Darksonn
Darksonn approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@carllerche carllerche merged commit 2e05399 into tokio-rs:master Oct 9, 2020
@taiki-e taiki-e deleted the sync-broadcast-error branch October 9, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taiki-e @Darksonn @carllerche