time: move error types into time::error
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
carllerche
reviewed
Oct 9, 2020
tokio/src/time/mod.rs
Outdated
| @@ -99,7 +99,7 @@ pub use sleep::{sleep, sleep_until, Sleep}; | |||
| pub(crate) mod driver; | |||
|
|
|||
| mod error; | |||
| pub use error::Error; | |||
| pub use error::{Elapsed, Error}; | |||
There was a problem hiding this comment.
This import should be removed. Then we can avoid cluttering the main namespace with error types :)
There was a problem hiding this comment.
Fixed. Hopefully I understood correctly how they should be exposed.
There was a problem hiding this comment.
btw @alce I think he means just doing pub mod error then you can address each error variant via error::Elapsed etc.
LucioFranco
approved these changes
Oct 12, 2020
hawkw
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2928