Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: flush on shutdown #3009

Merged
merged 2 commits into from Oct 20, 2020
Merged

fs: flush on shutdown #3009

merged 2 commits into from Oct 20, 2020

Conversation

zaharidichev
Copy link
Contributor

Fixes: #2950

Motivation

file should be flushed on shutdown.

Solution

call poll_flush on shutdown

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-fs Module: tokio/fs labels Oct 20, 2020
@Darksonn
Copy link
Contributor

Would be nice to duplicate a test using flush and change it to use shutdown instead.

@Darksonn Darksonn merged commit 16e272e into tokio-rs:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-fs Module: tokio/fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is the shutdown impl of File incorrect?
2 participants
@zaharidichev @Darksonn