io: update AsyncFd to use Registration #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some code duplication between `AsyncFd` and `Registration`.
seanmonstar
approved these changes
Nov 10, 2020
hawkw
approved these changes
Nov 10, 2020
carllerche
commented
Nov 10, 2020
| // Being awoken by a rt drop does not return an error, currently... | ||
| let _ = futures::executor::block_on(readable).unwrap(); | ||
| // The future was initialized **before** dropping the rt | ||
| assert_err!(futures::executor::block_on(readable)); |
There was a problem hiding this comment.
This is fine, I think - I viewed it as spurious wakeups being allowable so the test tolerated this one as long as we eventually got to an Err.
Darksonn
added
A-tokio
bdonlan
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some code duplication between
AsyncFdandRegistration.The
AsyncFd::readiness()fn will now returnErrwhen the runtime is dropped. This lines up w/ socket types.I also reordered some code in
async_fd.rsto match the style used elsewhere (structs at the top, impls after).