Exposing write_buffer on FramedWrite/Framed for consistency with FramedRead #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e consistent with the exposed read_buffer methods
Darksonn
added
A-tokio-util
tesaguri
added a commit
to tesaguri/tokio
that referenced
this pull request
Jan 10, 2021
- codec: `get_ref()`, `get_mut()`, `get_pin_mut()` and `into_inner()` for `Framed`, `FramedRead`, `FramedWrite`, `StreamReader`, `StreamReader`, `StreamReader` and `StreamReader` (tokio-rs#3364). - codec: `write_buffer()` and `write_buffer_mut()` for `Framed` and `FramedWrite` (tokio-rs#3387).
tesaguri
added a commit
to tesaguri/tokio
that referenced
this pull request
Jan 10, 2021
- codec: `get_ref()`, `get_mut()`, `get_pin_mut()` and `into_inner()` for `Framed`, `FramedRead`, `FramedWrite`, `StreamReader`, `StreamReader`, `StreamReader` and `StreamReader` (tokio-rs#3364). - codec: `write_buffer()` and `write_buffer_mut()` for `Framed` and `FramedWrite` (tokio-rs#3387).
tesaguri
added a commit
to tesaguri/tokio
that referenced
this pull request
Jan 10, 2021
# 0.6.1 (January 10, 2020) ### Added - codec: `get_ref()`, `get_mut()`, `get_pin_mut()` and `into_inner()` for `Framed`, `FramedRead`, `FramedWrite`, `StreamReader`, `StreamReader`, `StreamReader` and `StreamReader` (tokio-rs#3364). - codec: `write_buffer()` and `write_buffer_mut()` for `Framed` and `FramedWrite` (tokio-rs#3387).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have a scenario where given a specific event trigger, I need to consider all data in my Framed object is invalid, and I need to clear all of it. The framed object already exposes the read_buffer, I am just exposing the corresponding write buffer, so that I can clear that data as well.
Solution
Copying the API used for read_buffer in the FramedWrite/Framed files as well.