Any delimiter codec #3406
Merged
Any delimiter codec #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio-util
Darksonn
reviewed
Jan 16, 2021
Darksonn
reviewed
Jan 23, 2021
use simple &[u8] instead of &str and remove requirment for 'static
Darksonn
reviewed
Feb 8, 2021
Change the Item to Bytes
Darksonn
reviewed
Feb 20, 2021
and then discard all bytes till separator while returning Ok(None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To provide codecs that can be used with custom delimiters and encoder characters. The codex will decide based on any character found in the given delimiter characters.
Solution
This will work similarly to LinesCodec by trying to find any of the characters while decoding , and appending all of the given characters while encoding.