util: add PollSemaphore::{add_permits, available_permits}
#3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation The `tokio::sync::Semaphore` type provides a [`Semaphore::available_permits` method][1] which returns the current number of permits available on the semaphore. `tokio_util::sync::PollSemaphore` [does not expose such a method][2]. It is possible to use `PollSemaphore::into_inner` or `PollSemaphore::clone_inner` to unwrap the inner semaphore, but this may require cloning/dropping the semaphore's `Arc` which shouldn't be necessary to access the permits. ## Solution This commit adds `PollSemaphore::available_permits`. It also adds `PollSemaphore::add_permits` while we're here. [1]: https://docs.rs/tokio/1.4.0/tokio/sync/struct.Semaphore.html#method.available_permits [2]: https://docs.rs/tokio-util/0.6.5/tokio_util/sync/struct.PollSemaphore.html#implementations
|
Do you want to add |
Darksonn
approved these changes
Apr 7, 2021
Can do, I wasn't sure whether or not we wanted to expose all the API surface of the |
|
FreeBSD build failure looks unrelated? |
|
I am fine with exposing access to the |
Darksonn
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
tokio::sync::Semaphoretype provides aSemaphore::available_permitsmethod which returns the currentnumber of permits available on the semaphore.
tokio_util::sync::PollSemaphoredoes not expose such a method. Itis possible to use
PollSemaphore::into_innerorPollSemaphore::clone_innerto unwrap the inner semaphore, but this mayrequire cloning/dropping the semaphore's
Arcwhich shouldn't benecessary to access the permits.
Solution
This commit adds
PollSemaphore::available_permits. It also addsPollSemaphore::add_permitswhile we're here.Closes #3682