stream: impl FromIterator for StreamMap #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Aug 22, 2021
tokio-stream/src/stream_map.rs
Outdated
Comment on lines
588
to
595
| impl<K, V> IntoIterator for StreamMap<K, V> { | ||
| type Item = (K, V); | ||
| type IntoIter = std::vec::IntoIter<Self::Item>; | ||
|
|
||
| fn into_iter(self) -> Self::IntoIter { | ||
| self.entries.into_iter() | ||
| } | ||
| } |
There was a problem hiding this comment.
Implementing IntoIterator for this type seems very confusing since it also implements Stream, but has a different item type as a Stream.
There was a problem hiding this comment.
You're right. I'm not sure if implementing Extend makes a lot of sense if StreamMap doesn't implement IntoIterator. I removed both Extend and IntoIterator impls if you feel like Extend makes sense I can add it back.
Darksonn
added
A-tokio-stream
Darksonn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to collect iterator into a
StreamMapand to extendStreamMapwith another oneCloses #3982.