Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: implement try_recv for mpsc channels #4113

Merged
merged 5 commits into from
Sep 18, 2021
Merged

sync: implement try_recv for mpsc channels #4113

merged 5 commits into from
Sep 18, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Sep 15, 2021 •
edited
Loading

Implement mpsc::Receiver::try_recv and mpsc::UnboundedReceiver::try_recv.

Closes: #3350
Closes: #3639

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom Run loom tests on this PR labels Sep 15, 2021
carllerche
carllerche approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Straightforward. Thanks.

hawkw
hawkw approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concerns from me, either --- this looks great. thanks for the detailed comments!

@Darksonn Darksonn merged commit ddd33f2 into master Sep 18, 2021
@Darksonn Darksonn deleted the mpsc_try_recv branch September 18, 2021 07:27
@Darksonn Darksonn mentioned this pull request Sep 21, 2021
Merged
@softdevca softdevca mentioned this pull request Sep 21, 2021
Closed
@Darksonn Darksonn mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back mpsc try_recv
3 participants
@Darksonn @carllerche @hawkw