Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio: add riscv32 to non atomic64 architectures #4185

Merged
merged 1 commit into from Oct 20, 2021
Merged

tokio: add riscv32 to non atomic64 architectures #4185

merged 1 commit into from Oct 20, 2021

Conversation

jdspdx
Copy link
Contributor

@jdspdx jdspdx commented Oct 20, 2021

Motivation

Attempting to build a tokio based project for the riscv32 target architecture results in a compilation failure, due to lack of AtomicU64. The macro that checks this condition is based on a static list of architectures. The riscv32 architecture is not included in this check, so it defaults to std support for AtomicU64, which is incorrect. riscv32 does not have 64-bit atomics.

Solution

This PR simply adds riscv32 to the list of known architectures which do not have native AtomicU64. I've verified locally that projects build after this change.

@taiki-e taiki-e self-assigned this Oct 20, 2021
Copy link
Member

@taiki-e taiki-e left a comment

Thanks!

@taiki-e taiki-e merged commit eb7a615 into tokio-rs:master Oct 20, 2021
27 checks passed
@Darksonn Darksonn added the A-tokio label Oct 21, 2021
oliver-giersch pushed a commit to oliver-giersch/tokio that referenced this issue Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants