Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: refactored PollSender<T> to fix a subtly broken Sink<T> implementation #4214

Merged
merged 12 commits into from Feb 9, 2022
Merged

sync: refactored PollSender<T> to fix a subtly broken Sink<T> implementation #4214

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
72b0d08
sync: refactored PollSender<T> to fix a subtly broken Sink<T> impleme…
tobz Nov 3, 2021
885b81d
small comment tweaks + more thorough assertions in one test
tobz Nov 3, 2021
105c02c
address some feedback, add another test
tobz Nov 3, 2021
35d0a22
make poll_reserve more misuse-resistent + more tests
tobz Nov 3, 2021
ad4e690
more cleanup + tests
tobz Nov 3, 2021
4519da8
pub export for PollSendError<T>
tobz Nov 3, 2021
3fac48a
formatting
tobz Nov 3, 2021
2e8202f
drop unecessary bound
tobz Nov 3, 2021
eeb4abd
update doc comments per PR feedback
tobz Nov 9, 2021
4905e73
Merge branch 'master' into tobz/fix-poll-sender
tobz Dec 10, 2021
04413d6
slight naming tweaks
tobz Dec 10, 2021
b584b70
Merge branch 'master' into tobz/fix-poll-sender
tobz Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tokio-util/src/sync/mod.rs
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ pub use cancellation_token::{guard::DropGuard, CancellationToken, WaitForCancell
mod intrusive_double_linked_list;

mod mpsc;
pub use mpsc::PollSender;
pub use mpsc::{PollSendError, PollSender};

mod poll_semaphore;
pub use poll_semaphore::PollSemaphore;
Expand Down