Commits on Nov 15, 2021

1. sync: fix racy UnsafeCell access on a closed oneshot (#4226)

   

   hawkw committed Nov 15, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for ab0e60d
   • Browse repository at this point

   Copy the full SHA

   ab0e60d View commit details

   Browse the repository at this point in the history

2. oneshot: document UnsafeCell invariants (#4229) …

   Depends on #4226
   
   ## Motivation
   
   Currently, the safety invariants and synchronization strategy used in
   `tokio::sync::oneshot` are not particularly obvious, especially to a new
   reader. It would be nice to better document this code to make these
   invariants clearer.
   
   ## Solution
   
   This branch adds `SAFETY:` comments to the `oneshot` channel
   implementation. In particular, I've focused on documenting the
   invariants around when the inner `UnsafeCell` that stores the value can
   be accessed by the sender and receiver sides of the channel.
   
   I still want to take a closer look at when the waker cells can be set,
   and I'd like to add more documentation there in a follow-up branch.
   
   Signed-off-by: Eliza Weisman <eliza@buoyant.io>

   

   hawkw committed Nov 15, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 7d8de50
   • Browse repository at this point

   Copy the full SHA

   7d8de50 View commit details

   Browse the repository at this point in the history

3. chore: prepare Tokio v1.13.1 (#4235) …

   # 1.13.1 (November 15, 2021)
   
   ### Fixed
   
   - sync: fix a data race between `oneshot::Sender::send` and awaiting a
     `oneshot::Receiver` when the oneshot has been closed ([#4226])
   
   [#4226]: #4226

   

   hawkw committed Nov 15, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 2a3c803
   • Browse repository at this point

   Copy the full SHA

   2a3c803 View commit details

   Browse the repository at this point in the history