net: add buffer size methods to UdpSocket #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds: - UdpSocket::set_send_buffer_size - UdpSocket::send_buffer_size - UdpSocket::set_recv_buffer_size - UdpSocket::recv_buffer_size
Darksonn
reviewed
Dec 31, 2021
tokio/src/net/udp.rs
Outdated
Comment on lines
324
to
326
| fn to_socket(&self) -> socket2::SockRef<'_> { | ||
| socket2::SockRef::from(self) | ||
| } |
There was a problem hiding this comment.
According to the API guidelines, this should be called as_socket. It's not an expensive conversion.
Suggested change
| fn to_socket(&self) -> socket2::SockRef<'_> { | |
| socket2::SockRef::from(self) | |
| } | |
| fn as_socket(&self) -> socket2::SockRef<'_> { | |
| socket2::SockRef::from(self) | |
| } |
Darksonn
reviewed
Dec 31, 2021
tokio/src/net/udp.rs
Outdated
Comment on lines
259
to
261
| pub fn set_send_buffer_size(&self, size: u32) -> io::Result<()> { | ||
| self.to_socket().set_send_buffer_size(size as usize) | ||
| } |
There was a problem hiding this comment.
- socket2's set_send_buffer_size uses usize.
- tokio::net::TcpSocket's set_send_buffer_size uses u32.
This PR (tokio::net::UdpSocket) uses u32 for consistency with TcpSocket's methods, so we need casts here.
And as I said in #4270 (comment), these casts are fine.
- set_send_buffer_size,set_recv_buffer_size (cast u32 as usize): on tokio, usize is always at least 32 bits.
- send_buffer_size,recv_buffer_size (cast usize as u32): socket2 gets these values as c_int (always i32) and then cast them to usize (1, 2).
Darksonn
approved these changes
Dec 31, 2021
|
This was removed in aea26b3. Any chance we could bring it back? Or is there another alternative available already? |
|
Open an issue about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
Closes #3542
The first commit is from #4361.
Refs: