net: add tos and set_tos methods to TCP and UDP sockets #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Dec 31, 2021
tokio/src/net/tcp/socket.rs
Outdated
Comment on lines
393
to
410
| #[cfg(not(any( | ||
| target_os = "fuchsia", | ||
| target_os = "redox", | ||
| target_os = "solaris", | ||
| target_os = "illumos", | ||
| )))] | ||
| #[cfg_attr( | ||
| docsrs, | ||
| doc(cfg(all( | ||
| unix, | ||
| not(any( | ||
| target_os = "fuchsia", | ||
| target_os = "redox", | ||
| target_os = "solaris", | ||
| target_os = "illumos", | ||
| )) | ||
| ))) | ||
| )] |
There was a problem hiding this comment.
One of these includes a all(unix, ...) and the other doesn't. Why?
There was a problem hiding this comment.
Good catch. I forgot to remove all(unix, ...) when I copied the doc cfg from TcpSocket::reuseport.
Darksonn
reviewed
Dec 31, 2021
tokio/src/net/udp.rs
Outdated
Comment on lines
1561
to
1563
| fn to_socket(&self) -> socket2::SockRef<'_> { | ||
| socket2::SockRef::from(self) | ||
| } |
There was a problem hiding this comment.
Like I commented on the other PR, it is more idiomatic to call it as_socket.
Suggested change
| fn to_socket(&self) -> socket2::SockRef<'_> { | |
| socket2::SockRef::from(self) | |
| } | |
| fn as_socket(&self) -> socket2::SockRef<'_> { | |
| socket2::SockRef::from(self) | |
| } |
Darksonn
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3545
cc #3082
The first commit is from #4361.
Refs: