New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocking lock methods to RwLock
#4425
Merged
Darksonn
merged 2 commits into
tokio-rs:master
from
danielhenrymantilla:add_blocking_lock_methods_to_rwlock
Jan 27, 2022
Merged
Add blocking lock methods to RwLock
#4425
Darksonn
merged 2 commits into
tokio-rs:master
from
danielhenrymantilla:add_blocking_lock_methods_to_rwlock
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6b5531
to
f5c1f0b
Compare
Darksonn
reviewed
Jan 25, 2022
tokio/src/sync/mutex.rs
Outdated
/// - Consider using [`spawn_blocking()`][crate::runtime::Handle::spawn_blocking] | ||
/// (or [`block_in_place()`][crate::task::block_in_place]) to call, when | ||
/// within an asynchronrous execution context, any function that may | ||
/// call one of these `blocking_` operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is rather awkward.
deb5389
to
48894c3
Compare
Co-Authored-By: Alice Ryhl <alice@ryhl.io>
48894c3
to
376defc
Compare
Darksonn
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Same as #4130, but for
RwLock
this time.