stream: expose Elapsed
#4502
Merged
stream: expose Elapsed
#4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Feb 15, 2022
Darksonn
added
A-tokio-stream
|
Is there anything need to complete? |
Darksonn
reviewed
Feb 25, 2022
Comment on lines
+80
to
+82
| cfg_time! { | ||
| pub use stream_ext::timeout::Elapsed; | ||
| } |
There was a problem hiding this comment.
My main concern is whether this should be in a dedicated module or not.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We cannot use an error on
StreamExt::timeout()Solution
Expose
Elapsedastokio_stream::ElapsedNote
It seems #4286 points the same issue but it looked like it had stopped while so I made a new one.