Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: implement JoinMap #4538

Closed
wants to merge 43 commits into from
Closed
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8992cdc
rt: add internal `AbortHandle` type
hawkw Feb 23, 2022
48dbc38
rt: add abort handle to task combination tests
hawkw Feb 23, 2022
f18bb86
rt: make `AbortHandle::abort` consume `self`
hawkw Feb 23, 2022
87fe715
rt: expose `JoinHandle` with tokio-unstable
hawkw Feb 23, 2022
2a61f48
task: add `AbortHandle` to `JoinSet`
hawkw Feb 23, 2022
87d4ed0
fix missing `tokio_unstable` docs
hawkw Feb 23, 2022
107f78c
fix wasm tests i guess
hawkw Feb 23, 2022
9dac5b6
+rustfmt
hawkw Feb 23, 2022
b6dd2fd
Update tokio/src/runtime/task/join.rs
hawkw Feb 24, 2022
d77c9be
cleanup feature flags, add abort module
hawkw Feb 24, 2022
81a1658
rough draft JoinMap API
hawkw Feb 24, 2022
32c3a7c
don't leak panicked/canceled tasks; add task status
hawkw Feb 24, 2022
03d1bf9
add boilerplate hashmap capacity management
hawkw Feb 24, 2022
45baa74
add `abort_matching`
hawkw Feb 24, 2022
ec7e142
Merge branch 'master' into eliza/join-map
hawkw Feb 24, 2022
c4f6b7f
rewrite `JoinMap` to avoid O(_n_) `retain`s, move to `tokio`
hawkw Feb 25, 2022
9e579cf
reimpl `abort_matching` without `drain_filter`
hawkw Feb 25, 2022
07df256
remove task status from `AbortHandle` public API
hawkw Feb 25, 2022
35a576a
docs fixy-uppy
hawkw Feb 25, 2022
38feddc
Merge branch 'master' into eliza/join-map
hawkw Feb 25, 2022
6b082cc
clean up imports
hawkw Feb 26, 2022
bcb0803
add missing `must_use`
hawkw Feb 26, 2022
d5ddb34
abort `AbortHandle`s by reference
hawkw Feb 26, 2022
4c4b7a8
add a pile of tests
hawkw Feb 28, 2022
7bcf673
remove needless `Send` bounds
hawkw Mar 2, 2022
ffa9ffe
docs fixup
hawkw Mar 2, 2022
5dd4ed8
misc review feedback (thanks @Darksonn)
hawkw Mar 2, 2022
316c921
update with_capacity/reserve docs
hawkw Mar 2, 2022
3be7e1e
undo tokio-util version bump
hawkw Mar 2, 2022
051ffb5
wip
hawkw Mar 2, 2022
6060058
working, but ugly, implementation of alice's arc idea
hawkw Mar 2, 2022
91cf8ed
reduce changes to `IdleNotifiedSet` a lot; simplify implementation
hawkw Mar 4, 2022
ec3b1f3
go back to always returning keys, as god intended
hawkw Mar 4, 2022
437897f
nicer naming
hawkw Mar 4, 2022
c9fd8ab
improve naming and add comments
hawkw Mar 4, 2022
f609a44
use loom arc
hawkw Mar 4, 2022
69a1c80
remove `hashbrown` dependency
hawkw Mar 7, 2022
3bce69b
add comments, use `HashSet` rather than `HashMap`
hawkw Mar 7, 2022
07f0122
docs cleanup
hawkw Mar 11, 2022
f1a01d0
add examples to docs
hawkw Mar 11, 2022
eab0f7a
fixup doctests
hawkw Mar 11, 2022
a46ddc0
remove bonus backticks
hawkw Mar 11, 2022
e02a605
Merge branch 'master' into eliza/join-map
hawkw Mar 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tokio/src/runtime/task/abort.rs
Expand Up @@ -42,7 +42,7 @@ impl AbortHandle {
// the `AbortHandle` type is only publicly exposed when `tokio_unstable` is
// enabled, but it is still defined for testing purposes.
#[cfg_attr(not(tokio_unstable), allow(unreachable_pub))]
pub fn abort(self) {
pub fn abort(&self) {
if let Some(raw) = self.raw {
raw.remote_abort();
}
Expand Down