Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: complete TODOs in uds_stream. #4587

Merged
merged 1 commit into from
Mar 28, 2022
Merged

tests: complete TODOs in uds_stream. #4587

merged 1 commit into from
Mar 28, 2022

Conversation

arashsm79
Copy link
Contributor

This completes the TODOs in uds_stream accept_read_write test by
using AsyncWriteExt::write_all instead of AsyncWriteExt::write and
AsyncReadExt::read_to_end instead of AsyncReadExt::read_exact.

Motivation

Complete the TODOs in uds_stream accept_read_write test.

Solution

Use AsyncWriteExt::write_all instead of AsyncWriteExt::write and
AsyncReadExt::read_to_end instead of AsyncReadExt::read_exact.

@arashsm79
tests: complete TODOs in uds_stream.
6094ac6 
This completes the TODOs in uds_stream `accept_read_write` test by
using `AsyncWriteExt::write_all` instead of `AsyncWriteExt::write` and
`AsyncReadExt::read_to_end` instead of `read_exact`.
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Mar 28, 2022
Darksonn
Darksonn approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn enabled auto-merge (squash) March 28, 2022 19:29
@Darksonn Darksonn merged commit 702d6dc into tokio-rs:master Mar 28, 2022
@arashsm79 arashsm79 deleted the todo_usd_stream_test branch March 29, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arashsm79 @Darksonn