Improve LocalPoolHandle #4680
Merged
Improve LocalPoolHandle #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio-util
Darksonn
reviewed
May 11, 2022
b-naber
force-pushed
the
local-pool-handle
branch
2 times, most recently
from
2c23c9c
to
aca3e04
Compare
|
@Darksonn Addressed your review. |
Darksonn
reviewed
May 14, 2022
b-naber
force-pushed
the
local-pool-handle
branch
from
58ed9ac
to
2d8f30c
Compare
Darksonn
reviewed
May 17, 2022
b-naber
force-pushed
the
local-pool-handle
branch
from
71c63c0
to
31178f2
Compare
Darksonn
reviewed
May 17, 2022
Darksonn
reviewed
May 17, 2022
✅ Deploy Preview for tokio-rs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@Darksonn Updated the PR. |
b-naber
force-pushed
the
local-pool-handle
branch
from
1368c20
to
fe3f28d
Compare
|
Your doc-tests don't compile. |
b-naber
force-pushed
the
local-pool-handle
branch
from
fe3f28d
to
8a2f723
Compare
… a loop to spawn a task on all threads
b-naber
force-pushed
the
local-pool-handle
branch
from
8a2f723
to
5e72463
Compare
Darksonn
reviewed
May 29, 2022
tokio-util/src/task/spawn_pinned.rs
Outdated
Comment on lines
164
to
166
| /// let _ = handles | ||
| /// .into_iter() | ||
| /// .map(|handle| async { handle.await.unwrap() }); |
There was a problem hiding this comment.
This doesn't actually await them because iterators are lazy. Just use a for loop over handles instead.
Suggested change
| /// let _ = handles | |
| /// .into_iter() | |
| /// .map(|handle| async { handle.await.unwrap() }); | |
| /// for handle in handles { | |
| /// handle.await.unwrap(); | |
| /// } |
|
I believe everything this is missing is a bit of documentation stuff. Are you able to finish the PR? |
I forgot that you replied to this, sorry about that. Is there anything else that needs to be changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some functionality to
LocalPoolHandleand tries to improve existing docs.Fixes #4661