New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokio-fs: Add async versions of most of std::fs #494
Conversation
Excellent job 👍. I will schedule time to review this today. |
Looks great. Unfortunately, Tokio still needs to support slightly older Rust versions. Would you mind updating the doc tests to avoid using |
@carllerche I have updated the @lnicola the functions are now exported under |
tokio-fs/src/os/windows/mod.rs
Outdated
mod symlink_dir; | ||
mod symlink_file; | ||
|
||
pub use symlink_dir::{symlink_dir, SymlinkDirFuture}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing self::
, maybe? This failed on AppVeyor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was two missing self::
@carllerche @lnicola I have fixed the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great, thanks!
tokio-fs
was missing most of the the functions defined instd::fs
so this pull request simple adds most of them with implementations based onmetadata
.I have added each function as its own commit so that the commits are very simple and easy to read.