Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl std::io::BufRead on SyncIoBridge<T> if T: AsyncBufRead + Unpin #5265

merged 1 commit into from Dec 5, 2022


Copy link

@NobodyXu NobodyXu commented Dec 5, 2022

Signed-off-by: Jiahao XU


Since SyncIoBridge<T> implements std::io::Read if T: AsyncRead + Unpin, it will be nature to assume that it will also implement std::io::BufRead if T: AsyncBufRead + Unpin.


Signed-off-by: Jiahao XU <>
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-io Module: tokio/io labels Dec 5, 2022
Copy link

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@Darksonn Darksonn merged commit a1316cd into tokio-rs:master Dec 5, 2022
51 checks passed
@NobodyXu NobodyXu deleted the impl-BufRead-on-SyncIoBridge branch December 5, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
A-tokio-util Area: The tokio-util crate M-io Module: tokio/io
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants