/ tokio Public
sync: Heap allocate the values array #5294
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
See the issue #5293. Large types can cause a stack overflow for MPSC channels, in the
The only solution I could think of that doesn't involve cursed heap manipulation or gradual initialization (we need to bump the MSRV to do this soundly) is to just allocate the
Valuesarray on the heap and then initialize it from there.