Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routine dependencies update #533

Merged
merged 2 commits into from Aug 10, 2018
Merged

Routine dependencies update #533

merged 2 commits into from Aug 10, 2018

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 8, 2018

env_logger::init() now panics if it's already initialised.
All the tests passed on Linux.

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@mati865
Copy link
Contributor Author

mati865 commented Aug 8, 2018

I've missed recently added tokio-tls, going to fix that.

@mati865
Copy link
Contributor Author

mati865 commented Aug 8, 2018

Hmm, deprecated https://github.com/rust-lang-deprecated/tempdir still pulls rand 0.4.
Should I replace it with tempfile?

@mati865
Copy link
Contributor Author

mati865 commented Aug 8, 2018

I was getting Error(Shutdown) trying to fix tokio-threadpool\examples\smoke.rs for tokio-timer = "0.2".
In the end just reverted it to tokio-timer = "0.1", CI should pass now.

@carllerche
Copy link
Member

Should I replace it with tempfile?

Sure

Re Error(Shutdown) it would be nice to be able to use tokio-timer 0.2, but I can try to make that update later.

@mati865
Copy link
Contributor Author

mati865 commented Aug 8, 2018

I was running cargo test with out --all before. Now everything seems fine.

@tobz
Copy link
Member

tobz commented Aug 9, 2018

@carllerche looks like this is ready for merge?

@carllerche
Copy link
Member

Ag... looks like there are conflicts :( sorry.

@mati865
Copy link
Contributor Author

mati865 commented Aug 10, 2018

No problem, all green now.

NOTE: tokio-timer dev-dependency for threadpool is still outdated.

@seanmonstar seanmonstar merged commit 31f71de into tokio-rs:master Aug 10, 2018
@seanmonstar
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants