Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Remove erroneous wake call in SinkWriter #5436

Merged
merged 2 commits into from
Feb 7, 2023
Merged

bugfix: Remove erroneous wake call in SinkWriter #5436

merged 2 commits into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. bugfix: Remove erroneous wake call in SinkWriter 

    Per review comment tokio-rs#5070 (comment):
> Adding a wake call here will be a busy loop that consumes 100% CPU
> waiting for it to become ready. We shouldn't do that.

Furthermore, according to
https://docs.rs/futures-sink/latest/futures_sink/trait.Sink.html#tymethod.poll_ready,
poll_ready will make sure that the current task is notified.

Discussion: https://discord.com/channels/500028886025895936/500336346770964480/1072534504981418024
    @funbringer
    funbringer committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    33e7e91 View commit details
    Browse the repository at this point in the history

  2. Update tokio-util/src/io/sink_writer.rs 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @funbringer @Darksonn
    funbringer and Darksonn committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8fe91be View commit details
    Browse the repository at this point in the history