Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: make CancellationToken UnwindSafe #5438

Merged
merged 1 commit into from
Feb 9, 2023
Merged

sync: make CancellationToken UnwindSafe #5438

merged 1 commit into from
Feb 9, 2023

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Feb 8, 2023

Closes: #5424

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync labels Feb 8, 2023
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Feb 8, 2023
@Darksonn Darksonn mentioned this pull request Feb 9, 2023
Merged
hds
hds approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Darksonn Darksonn merged commit 8b44077 into master Feb 9, 2023
@Darksonn Darksonn deleted the cancel-token-unwindsafe branch February 9, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hds hds hds approved these changes

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CancellationToken is no longer UnwindSafe in tokio-util 0.7.2
2 participants
@Darksonn @hds