tokio_stream::StreamMap extend() - do not allow duplicate keys #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kable. However, this implementation does not allow duplicate keys and would overwrite existing ones similar to from_iter() behaviour. Initially introduced: PR tokio-rs#4272 - tokio-rs#4272 Note: can not implement Extend trait, since this method has stricter requirements than trait, as Extend does not require Key to be 'Eq + Hash' Issue tokio-rs#4774 - tokio-rs#4774
Darksonn
added
M-stream
|
This is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio_stream::StreamMap extend() - do not allow duplicate keys
Motivation
Issue #4774
Solution
A naive polynomial time complexity implementation that might be unworkable. However, this implementation does not allow duplicate keys and would overwrite existing ones similar to
from_iter()behavior.Initially introduced
PR #4272
Note
Can not implement Extend trait, since this method has stricter requirements than trait, as Extend does not require Key to be
Eq + Hash