Add stream ext #573
Merged
Add stream ext #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @carllerche Followup to #558. |
carllerche
previously requested changes
Aug 28, 2018
tests/timer.rs
Outdated
| @@ -71,6 +71,7 @@ fn starving() { | |||
| rx.recv().unwrap(); | |||
| } | |||
|
|
|||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
Could you remove this? I assume you get a warning. We should fix this in a follow up PR by updating the test.
There was a problem hiding this comment.
I removed the commit which had this.
mathstuf
force-pushed
the
add-stream-ext
branch
from
14da312
to
1310ba5
Compare
hawkw
dismissed
carllerche’s stale review
The commit that added the #[allow(deprecated)] was removed from this branch.
|
Ping? |
|
@mathstuf Can you rebase? That should pull in some changes which fix the broken unit tests. |
Primarily, it offers a `timeout` method for streams.
mathstuf
force-pushed
the
add-stream-ext
branch
from
1310ba5
to
b89ec6b
Compare
|
Rebased. |
|
Thanks for pinging me... Sorry for letting this slip. |
carllerche
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.