tokio-util: add AsyncRead/AsyncWrite passthrough for inspect #5739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows you to use
InspectReader
andInspectWriter
on types that implement both AsyncRead + AsyncWriter without losing those trait implementations.Motivation
While implementing clients for tcp interfaces it can be helpful to inspect the bytes sent / received through a
tokio::io::TcpStream
. The existing InspectReader / InspectWriter structs are a good start, but using them causes the stream to lose its AsyncWrite / AsyncRead trait impls.Solution
By adding implementations for
AsyncRead
toInspectWriter
andAsyncWrite
toInspectReader
it is now possible to inspect bytes sent through aTcpStream
(or any otherT: AsyncRead+AsyncWrite
) and still pass that stream onto another subsystem that expects aT: AsyncRead+AsyncWrite
.For example: