tokio: add builder function for watch::Sender #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method that allows to build a Sender without specifying any Receiver.
Darksonn
reviewed
Sep 10, 2023
This reverts commit 94b5392.
Added a function that basically calls the watch::channel function and drops the returned receiver
Darksonn
reviewed
Sep 11, 2023
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Darksonn
reviewed
Sep 11, 2023
nicflower
force-pushed
the
watch_builder
branch
from
edf2d61
to
7012700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Completing feature request #4958 regarding the watch channel part
Solution
Simply added a new builder function that takes as argument the initial value of the watched value. I used this builder also in the watch::channel function, because of this it made the Version::Initial funcion not used so I removed it