-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fixing failures with the latest compilers #6255
Conversation
d5dc12b
to
7d74458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
#[allow(unused_imports)] | ||
pub use poll_fn::poll_fn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
#[allow(unused_imports)] | |
pub use poll_fn::poll_fn; | |
pub(crate) use poll_fn::poll_fn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Darksonn
Hmmm, that change doesn't seem to work. 🤔 (I tried it on the fork branch.)
error[E0364]: `poll_fn` is only public within the crate, and cannot be re-exported outside
--> tokio/src/macros/support.rs:2:13
|
2 | pub use crate::future::poll_fn;
| ^^^^^^^^^^^^^^^^^^^^^^
|
note: consider marking `poll_fn` as `pub` in the imported module
--> tokio/src/macros/support.rs:2:13
|
2 | pub use crate::future::poll_fn;
| ^^^^^^^^^^^^^^^^^^^^^^
error: unused import: `crate::future::poll_fn`
--> tokio/src/macros/support.rs:2:13
|
2 | pub use crate::future::poll_fn;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
I've tried other things, but I haven't figured out a good way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This try to fix errors occured with the latest 1.75.0 compiler changes.
How to fail can be found here.