Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing failures with the latest compilers #6255

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mox692
Copy link
Member

@mox692 mox692 commented Dec 29, 2023

This try to fix errors occured with the latest 1.75.0 compiler changes.

How to fail can be found here.

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +9 to 10
#[allow(unused_imports)]
pub use poll_fn::poll_fn;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?

Suggested change
#[allow(unused_imports)]
pub use poll_fn::poll_fn;
pub(crate) use poll_fn::poll_fn;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darksonn
Hmmm, that change doesn't seem to work. 🤔 (I tried it on the fork branch.)

error[E0364]: `poll_fn` is only public within the crate, and cannot be re-exported outside
 --> tokio/src/macros/support.rs:2:13
  |
2 |     pub use crate::future::poll_fn;
  |             ^^^^^^^^^^^^^^^^^^^^^^
  |
note: consider marking `poll_fn` as `pub` in the imported module
 --> tokio/src/macros/support.rs:2:13
  |
2 |     pub use crate::future::poll_fn;
  |             ^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `crate::future::poll_fn`
 --> tokio/src/macros/support.rs:2:13
  |
2 |     pub use crate::future::poll_fn;
  |             ^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

I've tried other things, but I haven't figured out a good way.

@Darksonn Darksonn added A-tokio Area: The main tokio crate A-ci Area: The continuous integration setup labels Dec 29, 2023
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 5f7fe8f into tokio-rs:master Dec 29, 2023
76 checks passed
@mox692 mox692 deleted the fix-75-failure branch December 29, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants