Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: explain relation between watch::Sender::{subscribe,closed} #6490

Merged
merged 2 commits into from
Apr 17, 2024
Merged

sync: explain relation between watch::Sender::{subscribe,closed} #6490

merged 2 commits into from
Apr 17, 2024

Conversation

Darksonn
Copy link
Contributor

Closes: #6489

@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Apr 16, 2024
@Darksonn Darksonn requested a review from mox692 April 16, 2024 18:10
@github-actions github-actions bot added the R-loom-sync Run loom sync tests on this PR label Apr 16, 2024
@Darksonn
sync: explain relation between watch::Sender::{subscribe,closed}
066c54c 
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
mox692
mox692 reviewed Apr 17, 2024
View reviewed changes
tokio/src/sync/watch.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn merged commit 9c6ff3b into master Apr 17, 2024
75 checks passed
@Darksonn Darksonn deleted the alice/watch-closed-doc branch April 17, 2024 14:16
@Darksonn Darksonn mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mox692 mox692 mox692 approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom-sync Run loom sync tests on this PR T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify how watch::Sender subscribe() and closed() methods interact
2 participants
@Darksonn @mox692