io: add copy_bidirectional_with_sizes
#6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as `copy_bidirectional` but accepts the `a` -> `b` and `b` -> `a` buffers sizes. `copy_bidirectional` uses 8Kb buffers under the hood which isn't configurable. `copy_bidirectional_with_size` fixes it by allowing an user to set its own sizes for underlying buffers. Fixes: tokio-rs#6454. Refs: tokio-rs#3572.
RRRadicalEdward
force-pushed
the
copy_bidirectional_with_size
branch
from
776f21b
to
90315d2
Compare
dd-dreams
reviewed
Apr 20, 2024
RRRadicalEdward
changed the title
copy_bidirectional_with_sizecopy_bidirectional_with_sizes
Co-authored-by: Motoyuki Kimura <moymoymox@gmail.com>
dd-dreams
approved these changes
Apr 21, 2024
Darksonn
reviewed
Apr 22, 2024
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
copy_bidirectionaluses 8Kb buffers under the hood, which isn't configurable.Solution
New method
copy_bidirectional_with_sizeswere added which but accepts thea->bandb->abuffers sizes. This way, a user can pass the desire buffers sizes.I extracted common
copy_bidirectionallogic intocopy_bidirectional_implwhichcopy_bidirectionalandcopy_bidirectional_with_sizesuses.Fixes: #6454.
Refs: #3572.