io: fix trait bounds on impl Sink for StreamReader
#6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This impl had a bound on `StreamReader<S, E>`; this is incorrect because: - The second generic parameter to `StreamReader` is not an error type; it's a buffer type. - The `Stream` error type in `StreamReader` should not need to be the same as the `Sink` error type. This "passthrough" `Sink` impl was effectively unusable because it required the `Sink` error type be the same as the `StreamReader` buffer type. Resolve this by allowing the `StreamReader` buffer to be anything in this impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl had a bound on
StreamReader<S, E>; this is incorrect because the second generic parameter toStreamReaderis not an error type; it's a buffer type.Motivation
This "passthrough"
Sinkimpl is currently unusable because it requires theSinkerror type be the same as theStreamReaderbuffer type. This seems like it must have been a typo, because that constraint is not useful.See the example program in #6642 for more details.
Solution
Resolve this by removing the constraint on
StreamReader's buffer typeB. It's irrelevant to aSinkimpl anyway.Fixes #6642.