Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose keep_alive on the Runtime builder #676

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Expose keep_alive on the Runtime builder #676

merged 1 commit into from
Sep 29, 2018

Conversation

sfackler
Copy link
Contributor

This was overlooked when delegating the rest of the threadpool builder
methods from Runtime's builder.

@carllerche carllerche requested a review from a user September 28, 2018 18:52
@carllerche
Copy link
Member

Cc @stjepang I don’t think that this impacts anything that we are trying to do

@sfackler
Expose keep_alive on the Runtime builder
5f5ec46 
This was overlooked when delegating the rest of the threadpool builder
methods from Runtime's builder.
ghost
ghost suggested changes Sep 28, 2018
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now we have complete parity between runtime::Builder and threadpool::Builder apart from the plumbing methods (around_worker, after_start, before_stop, custom_park).

ghost
ghost approved these changes Sep 28, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to approve :)

@carllerche carllerche merged commit d06bd6b into tokio-rs:master Sep 29, 2018
@carllerche
Copy link
Member

Thanks @sfackler

@sfackler sfackler deleted the runtime-keep-alive branch October 23, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfackler @carllerche