Implement throttle combinator #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoLegends
force-pushed
the
feature/throttle
branch
from
f69bca4
to
b2f1df8
Compare
carllerche
requested changes
Nov 5, 2018
|
Could you merge master? This will hopefully fix the CI failure. |
NeoLegends
force-pushed
the
feature/throttle
branch
from
54b9d32
to
9524b59
Compare
|
Rebased. |
NeoLegends
force-pushed
the
feature/throttle
branch
from
8df065b
to
9c3df4a
Compare
This adds get_ref, get_mut and into_inner accessors to Throttle. This is how the futures library does it as well.
|
@NeoLegends Can we also add a test or two for this one? Same story as the comment I left on the debounce combinator. :P |
carllerche
approved these changes
Nov 19, 2018
NeoLegends
changed the title
|
Yes I am. :) |
|
Great 👍 Thanks for sticking with it and getting this done. Looks great. |
|
My pleasure. Please also see #747 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second combinator implementing #732 (comment).
I'm not really sure on the design of this one (especially since errors of the underlying stream will be delayed as well, but I assume this is a necessary evil since you'd want to use this to slow down things like
stream::repeat(_)that produce items at unbounded speeds), so I'm eager on your feedback.You might notice I added two extensions to
Stream, one that enforces a given delay, and another one that enforces a rate of items (and calculates the required delay from that). Not sure if both are necessary, but I felt they fit quite nicely.