threadpool: fix semaphore deadlock #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sfackler Are you able to test this patch to see if it resolves the issue you have been seeing? |
|
@stjepang the change looks good to me. I'm hoping to get some confirmation that it fixed the bug before merging. |
|
I'm probably not going to be able to test this, unfortunately. :( Certainly not before the new year. |
carllerche
approved these changes
Dec 12, 2018
|
Ok, we can merge & ship then... we'll test it live! |
|
Thanks for implementing the fix @stjepang |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a hotfix for #726. The semaphore used for allocating permits to call
blocking()could run into a deadlock, as explained in this comment.Solution
Call
consume_blocking_allocation()when running the task rather than before running the task.