Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async-await: fix build for latest nightly #940

Merged
merged 2 commits into from
Mar 1, 2019
Merged

async-await: fix build for latest nightly #940

merged 2 commits into from
Mar 1, 2019

Conversation

carllerche
Copy link
Member

Rust 2015 no longer supports the async fn syntax. However, we cannot update to Rust 2018
and remain backwards compatible.

To work around this, async fn is removed in favor of manually implementing futures.

Supersedes #935

@carllerche carllerche mentioned this pull request Mar 1, 2019
Closed
LucioFranco
LucioFranco approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carllerche carllerche merged commit 85e3bd3 into master Mar 1, 2019
@carllerche carllerche deleted the fix-async-await-nightly branch March 2, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carllerche @LucioFranco