Remove inconsistent address resolution #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency in address resolution / parsing.
The trait
ToIpAddr
interprets strings that can be parsed as anIpAddr
asdomain names instead of parsing the address.
ToSocketAddr
however willparse the Ip part of the address if possible. To remove this inconsistency
ToIpAddr
will now always interpret strings that can be parse to aIpAddr
asIpAddr
.Example
Without this change:
On a site note,
ToIpAddr
was not implemented forIpv4Addr
andIpv6Addr
whichwas problematic since APIs with
impl ToIpAddr
could not use.into()
due to missingtype inference. Same goes for
ToSocketAddr
withSocketAddrV4
andSocketAddrV6
respectivly(Tokio's
ToSocketAddr
does is implemented for these types)