Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephemeral port leak upon tcp stream shutdown #145

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

brightcoder
Copy link
Contributor

Do not send a Fin upon the write half drop if the stream is already shutdown but still perform the socket pair clean up.

Do not send a Fin upon the write half drop if the stream is
already shutdown but still perform the socket pair clean up.
@brightcoder brightcoder marked this pull request as ready for review November 3, 2023 19:55
@mcches mcches requested review from mh32 and mcches November 3, 2023 20:04
Copy link
Contributor

@mcches mcches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mcches mcches merged commit 68002cd into tokio-rs:main Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants